[Bug 790154] Review Request: python-mwlib - MediaWiki parser and utility library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790154

--- Comment #2 from Ian Weller <ian at ianweller.org> 2012-02-13 16:05:44 EST ---
(In reply to comment #1)
> Needswork:
> 
> * package doesn't build in koji -- needs:
>     BuildRequires: python-setuptools
>   - Tested that the package builds with that change made
> * Package needs Requires: python-setuptools since it uses import pkg_resources
>   in the code

Fixed in the version below.

> 
> 
> Cosmetic:
> 
> * rpmlint just has warnings for no man pages:
>   python-mwlib.x86_64: W: no-manual-page-for-binary mw-post (and all the other
>   %{_bindir} scripts).  These are warnings and if no man pages are easily
>   available, ignorable.

They aren't easily available so I plan to ignore :)

> Potential future issues:
> 
> * The package installs a toplevel argv.py file/module.  This seems to just be
>   used for the command line scripts for parsing the command line.  Since this
>   has the potential to pollute the python package namespace with a somewhat
>   common name, suggest to upstream that they may want to restructure like
>   this::
>     mv argv.py mwlib/._argv.py
>     sed s/import argv/from mwlib import _argv as argv/

/me sighs

I'll file a ticket with them.

* Mon Feb 13 2012 Ian Weller <iweller at redhat.com> - 0.13.3-3
- BuildRequires: python-setuptools
Files in http://ianweller.fedorapeople.org/SRPMS/python-mwlib/0.13.3-3/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.