[Bug 787364] Review Request: clipgrab - Streaming videos plate-forms grabber

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 13 21:51:02 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787364

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #3 from Volker Fröhlich <volker27 at gmx.at> 2012-02-13 16:51:01 EST ---
According to the code, license is GPLv3+.

Throw away the defattr line, it is not necessary. "rm -rf $RPM_BUILD_ROOT" is
outdated too.

Should that really be "plate-forms" and not "platform"?

As you're not defining or using MIME types, neither installing icons in the
hicolor directory, all of the scriptlets are useless.

Please preserve the timestamps when installing, where it makes sense. For
instance, use cp -p icon.png ...

Commonly _datadir is used instead of _datarootdir.

Please use the name macro consistently.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list