[Bug 598860] Review Request: httpd-itk - MPM Itk for Apache HTTP Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598860

--- Comment #13 from Nikos Roussos <nikos at autoverse.net> 2012-02-14 16:32:22 EST ---
Actually you're using tabs instead of spaces :) And in some cases you're mixing
them. Use either spaces or tabs (spaces preferable). It's not against the
policy, but it would make the spec far more readable.

Add some descriptive comments or/and upstream links on patches
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

You could add  build requires dependencies one per line. It's more readable.

Use the full length of a line for description, up to 80 characters.

I'm not sure it's a good idea to add an echo command on %install section. If
you want to give some information to the user, better add a README.Fedora or
add some info on description.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.