[Bug 771137] Review Request: decibel-audio-player - straightforward music player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771137

Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org

--- Comment #2 from Christoph Wickert <cwickert at fedoraproject.org> 2012-02-15 12:56:46 EST ---
When using sed, you are hardcoding /usr/bin. Use the %{_bindir} macro instead.

(In reply to comment #1)
> Just some comments:
> 
> - Drop defattr, it is no longer necessary

It *can* be dropped, but it does no harm, so IHMO there is no reason to drop
it. It's still needed on EPEL5.

> - Man pages should not be marked as documentation

Correct is: They will be marked as %doc automatically, so there is no need to
mark them in the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.