[Bug 790525] Review Request: rubygem-dynect_rest - Dynect REST API library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790525

John (J5) Palmieri <johnp at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #5 from John (J5) Palmieri <johnp at redhat.com> 2012-02-15 13:02:19 EST ---
Here are the ruby specific reviews, I'll go over the general package review
next:

* The Source of the package must be the full URL to the released Gem archive;
the version of the package must be the Gem's version

Pass

* The package must have a Requires and a BuildRequires on rubygems

Pass

* The package must provide rubygem(%{gemname}) where gemname is the name from
the Gem's specification. For every dependency on a Gem named gemdep, the
package must contain a Requires on rubygem(%{gemdep}) with the same version
constraints as the Gem

Pass

* The %prep and %build sections of the specfile should be empty.

Pass

* The Gem must be installed into %{gemdir} defined as 
  %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

Pass

* The install should be performed with the command
  gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}

Fail - please fix the cp lines to use gem install or justify why gem install
does not work


* The package must own the following files and directories: 
  %{gemdir}/gems/%{gemname}-%{version}/
  %{gemdir}/cache/%{gemname}-%{version}.gem
  %{gemdir}/specifications/%{gemname}-%{version}.gemspec


Fail - you exclude %{gemdir}/cache/%{gemname}-%{version}.gem

* If the Gem only contains pure Ruby code, it must be marked as BuildArch:
noarch.

Pass


Please fix all the MUST items.  Fix or justify why we should wave the SHOULD
items.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.