[Bug 790525] Review Request: rubygem-dynect_rest - Dynect REST API library

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 15 21:30:07 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790525

--- Comment #7 from John (J5) Palmieri <johnp at redhat.com> 2012-02-15 16:30:06 EST ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]


rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/rubygem-dynect_rest-0.4.0-2.fc18.noarch.rpm 
rubygem-dynect_rest.noarch: W: spelling-error Summary(en_US) Dynect -> Connect

 Waved - false positive - Dynect is the package name and not a word in itself

rubygem-dynect_rest.noarch: W: invalid-url URL:
http://github.com/adamhjk/dynect_rest <urlopen error [Errno 104] Connection
reset by peer>

 Waved - I manually checked this and it works

rubygem-dynect_rest.noarch: W: unexpanded-macro
/usr/share/gems/doc/dynect_rest-0.4.0/ri/DynectRest/Resource/%5b%5d%3d-i.ri %5b
rubygem-dynect_rest.noarch: W: unexpanded-macro
/usr/share/gems/doc/dynect_rest-0.4.0/ri/DynectRest/Resource/%5b%5d%3d-i.ri %5d
rubygem-dynect_rest.noarch: W: unexpanded-macro
/usr/share/gems/doc/dynect_rest-0.4.0/ri/DynectRest/Resource/%5b%5d%3d-i.ri %3d
rubygem-dynect_rest.noarch: W: unexpanded-macro
/usr/share/gems/doc/dynect_rest-0.4.0/ri/DynectRest/Resource/%5b%5d-i.ri %5b
rubygem-dynect_rest.noarch: W: unexpanded-macro
/usr/share/gems/doc/dynect_rest-0.4.0/ri/DynectRest/Resource/%5b%5d-i.ri %5d

 All waved - doc files used by ruby doc tools

rubygem-dynect_rest.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/doc/dynect_rest-0.4.0/ri/cache.ri

 waved - doc file used by doc tool

1 packages and 0 specfiles checked; 0 errors, 8 warnings.


Passed


MUST: The package must be named according to the Package Naming Guidelines .

Passed

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .

Passed

MUST: The package must meet the Packaging Guidelines

Passed

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .

Passed ASL 2.0

MUST: The License field in the package spec file must match the actual license.
[3]

Passed

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]

Passed

MUST: The spec file must be written in American English. [5]

Passed

MUST: The spec file for the package MUST be legible. [6]

Passed

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

Passed

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]

Passed - build in mock

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]

Passed - noarch

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

Passed

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]

Passed

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]

N/A - noarch

MUST: Packages must NOT bundle copies of system libraries.[11]

Passed

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]

Passed

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]

Passed

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]

Passed

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]

Passed

MUST: Each package must consistently use macros. [16]

Passed

MUST: The package must contain code, or permissable content. [17]

Passed

MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]

Needs Work - add a doc subpackage

MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]

Passed

MUST: Static libraries must be in a -static package. [19]

N/A - noarch

MUST: Development files must be in a -devel package. [20]

N/A - no devel files

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]

N/A - no devel files

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.[19]

N/A - noarch

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[22]

N/A - not a GUI package

MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. [23]

Passed 

MUST: All filenames in rpm packages must be valid UTF-8. [24]

Passed


Fix the doc subpackage and you are good to go

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list