[Bug 790215] Review Request: perl-Net-IP-Match-Regexp - Efficiently match IP addresses against ranges

Thu Feb 16 12:52:52 UTC 2012

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=790215

massimo.paladin at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |massimo.paladin at gmail.com

--- Comment #1 from massimo.paladin at gmail.com 2012-02-16 07:52:52 EST ---
Hi,

I am not an official package maintainer so I can make only an informal review.

Your package passed the fedora-review checks.

Only some notes:
- do you need "BuildRequires:  perl >= 1:5.6.0" ?
- instead of "./Build whatever" wouldn'it be nicer to put "%{__perl} Build
whatever"
- I believe you can remove "rm -rf $RPM_BUILD_ROOT" in %install and %clean
sections unless you want the package in EPEL 5 too
(https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag)
- "%defattr(-,root,root,-)" this can be removed for this reason
(https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions)

fedora-review report:

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[ ]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generates any conflict.
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[ ]: MUST Package installs properly.
[ ]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint perl-Net-IP-Match-Regexp-1.01-1.fc18.noarch.rpm

perl-Net-IP-Match-Regexp.noarch: W: spelling-error %description -l en_US
boolean -> Boolean, boo lean, boo-lean
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint perl-Net-IP-Match-Regexp-1.01-1.fc18.src.rpm

perl-Net-IP-Match-Regexp.src: W: spelling-error %description -l en_US boolean
-> Boolean, boo lean, boo-lean
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/mpaladin/rpmbuild/REVIEWS/790215/Net-IP-Match-Regexp-1.01.tar.gz :
  MD5SUM this package     : 5558a916d5d15884be949c9f7fc71a49
  MD5SUM upstream package : 5558a916d5d15884be949c9f7fc71a49

[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[ ]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[ ]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[ ]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[ ]: SHOULD %check is present and all tests pass.
[ ]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[!]: MUST Rpmlint output is silent.

rpmlint perl-Net-IP-Match-Regexp-1.01-1.fc18.noarch.rpm

perl-Net-IP-Match-Regexp.noarch: W: spelling-error %description -l en_US
boolean -> Boolean, boo lean, boo-lean
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint perl-Net-IP-Match-Regexp-1.01-1.fc18.src.rpm

perl-Net-IP-Match-Regexp.src: W: spelling-error %description -l en_US boolean
-> Boolean, boo lean, boo-lean
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.