[Bug 684006] Review Request: perl-XML-Rules - API layer for XML::Parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684006

--- Comment #5 from Paul Howarth <paul at city-fan.org> 2012-02-16 10:14:26 EST ---
You should add the shellbangs (and make any other changes to the sources) in
%prep rather than %install unless there's a good reason not to.

I think it would be more readable if you had each of the new buildreqs on a
separate line, like the existing ones.

You can drop the "Requires:" lines for perl(XML::Parser) and
perl(XML::Parser::Expat) altogether since rpm finds the dependencies itself and
the versions don't matter as discussed previously.

Let me know when you have an XML::DTDParser package to review; we should be
able to move forward with the sponsorship process then and get these things
into Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.