[Bug 791263] Review Request: mockito - A Java mocking framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=791263

Stanislav Ochotnicky <sochotni at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sochotni at redhat.com

--- Comment #1 from Stanislav Ochotnicky <sochotni at redhat.com> 2012-02-16 11:08:09 EST ---
Not a sponsor so just a few quick things:
 * Instead of having a patch adding the pom, add it as additional Source1
(direct link to maven repo or wherever) - you can refer to it later as
%{SOURCE1}
 * You are not installing license. Both main package and javadoc has to have
%doc LICENSE (and in this case also NOTICE)
 *  Instead of:
cp -p target/mockito-core-1.9.0.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
do:
cp -p target/mockito-core-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar

It will simplify updates
 * Some upstreams have complicated build systems that add certain files in
special places and then generate something else out of them. It means that if
you build "your way" you can inadvertently introduce changes into final binary
jars. That's why we usually (not always!) prefer to build from SCM over using
source jars. Best way to solve this long term: ask upstream to generate
-project.zip files with complete contents of SCM needed to build. I wouldn't
block a review on this, but I would urge you to be careful. Ugly things have
happened when building like this :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.