[Bug 782560] Review Request: rubygem-ruby-shadow - *nix Shadow Password Module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=782560

--- Comment #12 from Todd Zullinger <tmz at pobox.com> 2012-02-16 11:13:06 EST ---
Hey guys,

I made a few changes to the spec file to reflect manyof the changes already
suggested.  It also makes the spec file work for older Fedora and EPEL.

One difference from the provides is that I used:

Provides: ruby(shadow) = %{version}

instead of %{version}-%{release}.  The draft guidelines¹ say to use:

Provides: ruby(RUBYLIBRARY) = VERSION
Provides: rubygem(%{gem_name}) = %{version}

I don't know if the guidelines are just incorrect or not there.  It's an easy
change if either of you know what it should properly be.  The current
ruby-shadow rpm provides ruby(shadow) = %{version}-%{release}.

I made scratch builds for f1{6..8} and el{5,6}, but haven't done more than
poke at the file lists and provides/requires/obsoletes (i.e. I haven't
installed and used them at all yet).

f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=3796055
f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=3796089
f16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3796039
el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3796083
el5: http://koji.fedoraproject.org/koji/taskinfo?taskID=3796071

Spec file: http://tmz.fedorapeople.org/specs/rubygem-ruby-shadow.spec

I did make these changes to the spec *after* I did the scratch builds:

%{gem_dir}/specifications/%{gem_name}-%{version}.gemspec -> %{gem_spec}
%{gem_dir}/doc/%{gem_name}-%{version} -> %{gem_docdir}
%{gem_instdir}/lib -> %{gem_libdir}

I also left the BR: ruby(rubygems) because rubygems-devel is only available on
f17 and above.

This still leaves the question of the license open.

Hopefully this helps a little.  I'll try to find time to install and test this
later today, but no promises there.

¹ http://fedoraproject.org/wiki/PackagingDrafts/Ruby#RubyGems

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.