[Bug 791229] Review Request: authhub - OTP support for MIT Kerberos

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=791229

--- Comment #3 from Kashyap Chamarthy <kchamart at redhat.com> 2012-02-17 04:15:33 EST ---
(In reply to comment #2)
> - First off, no warnings from rpmlint. Nice thing
> kashyap at SRPMS$ rpmlint authhub-0.1.1-1.fc16.src.rpm ../SPECS/authhub.spec 
> 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
> kashyap at SRPMS$ ls
> 
> - I'm trying to build the pkg on my Fedora-16, but there is no
> 'libverto-jsonrpc' for F16 ; And my rawhide machine seems to be a little
> broken.
> 
> - Reviewing the spec, it looks nice.
> 
> Partial Review:
> ########################################################
> NA== Not Applicable 
> 
> OK - %{?dist} tag is used in release
> OK - The package must be named according to the Package Naming Guidelines.
> OK - The spec file name must match the base package %{name}
> OK - The package must meet the Packaging Guidelines
> 
> OK - The package must be licensed with a Fedora approved license and
> meet the Licensing Guidelines (license is MIT)
> 
> NA - Every binary RPM package which stores shared library files must
> call ldconfig in %post and %postun
> NA - Rationale provided for static linking
> OK - The package MUST successfully compile and build

(From the scratch build. I myself have to do it yet locally)
> 
> OK - The spec file must be written in American English.
> OK - The spec file for the package MUST be legible
> 
> 
> OK - A Fedora package must not list a file more than once in the spec file's
> %files listings
> NA - Permissions on files must be set properly
> OK - Each package must have a %clean section

OK because (from F-13 and above, it's not needed)

> OK - Each package must consistently use macros
> OK - The package must contain code, or permissible content 
> NA - Large documentation files must go in a -doc subpackage -- No large
> documentation
> NA - Header files must be in a -devel package.
> NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' - This
> is fetched as part of other deps.
> OK - Packages must NOT contain any .la libtool archives
> OK - No file conflicts with other packages and no general names.
> OK - All file names in rpm packages must be valid UTF-8
> OK - The package does not yet exist in Fedora. The Review Request is not a
> duplicate.
> OK - koji scratch build is successful (from Comment #1)
> ########################################################
> 
> Yet to do:
> ---------
> - Build the package
> - Verify the sources used to build the package must match the upstream source,
> as provided in the spec URL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.