[Bug 785923] Review Request: xgap - GUI for GAP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785923

--- Comment #4 from Volker Fröhlich <volker27 at gmx.at> 2012-02-17 10:19:33 EST ---
The desktop file has a number of flaws. I therefore attached a modified copy.

- Don't hardcode icons; I also wonder why this package has no icon but there is
an icon and a copy of this desktop file in gap-core, which is no desktop
application, as far as I can see.
- Is there really a MIME type? If so, you need a scriptlet.
- Would you really execute xgap handing over a list of URLs? (%U)
- "Comment" is shown as context help for the application and should give the
user a clue what that program does. You don't need a comment, but the original
comment is not suitable.

http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

Please use the name macro consistently. You're using it on some occasions, but
not on others, e. g. patch0.

Please always change the release number and write to the changelog. The
reviewer otherwise can easily miss out changes.

I wonder if everything installed in /usr/share/gap/pkg/xgap is really
necessary, for instance manual.dvi, manual.tex or Makefile. The same is true
for other gap packages. You might also consider to install the necessary files
with the doc macro and leave a link.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.