[Bug 791363] Review Request: perl-XML-DTDParser - Quick and dirty DTD parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=791363

Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |paul at city-fan.org
         AssignedTo|nobody at fedoraproject.org    |paul at city-fan.org

--- Comment #1 from Paul Howarth <paul at city-fan.org> 2012-02-17 10:36:56 EST ---
First pass:

Package fails to build in mock:

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.YlZXgq
+ umask 022
+ cd /builddir/build/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /builddir/build/BUILD
+ rm -rf XML-DTDParser-2.01
+ /usr/bin/gzip -dc /builddir/build/SOURCES/XML-DTDParser-2.01.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd XML-DTDParser-2.01
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.feEGiz
+ exit 0
+ umask 022
+ cd /builddir/build/BUILD
+ cd XML-DTDParser-2.01
+ LANG=C
+ export LANG
+ unset DISPLAY
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
Checking if your kit is complete...
Looks good
Writing Makefile for XML::DTDParser
+ make -j4
cp DTDParser.pm blib/lib/XML/DTDParser.pm
Manifying blib/man3/XML::DTDParser.3pm
+ find . -type f -exec sed -i 's/\r//' '{}' ';'
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.mHe7cJ
+ umask 022
+ cd /builddir/build/BUILD
+ '[' /builddir/build/BUILDROOT/perl-XML-DTDParser-2.01-1.fc18.x86_64 '!=' /
']'
+ rm -rf /builddir/build/BUILDROOT/perl-XML-DTDParser-2.01-1.fc18.x86_64
++ dirname /builddir/build/BUILDROOT/perl-XML-DTDParser-2.01-1.fc18.x86_64
+ mkdir -p /builddir/build/BUILDROOT
+ mkdir /builddir/build/BUILDROOT/perl-XML-DTDParser-2.01-1.fc18.x86_64
+ cd XML-DTDParser-2.01
+ LANG=C
+ export LANG
+ unset DISPLAY
+ rm -rf /builddir/build/BUILDROOT/perl-XML-DTDParser-2.01-1.fc18.x86_64
+ make pure_install
PERL_INSTALL_ROOT=/builddir/build/BUILDROOT/perl-XML-DTDParser-2.01-1.fc18.x86_64
Makefile out-of-date with respect to Makefile.PL
Cleaning current config before rebuilding Makefile...
make -f Makefile.old clean > /dev/null 2>&1
/usr/bin/perl Makefile.PL "INSTALLDIRS=vendor"
Checking if your kit is complete...
Looks good
Writing Makefile for XML::DTDParser
==> Your Makefile has been rebuilt. <==
==> Please rerun the make command.  <==
false
make: *** [Makefile] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.mHe7cJ (%install)
    Bad exit status from /var/tmp/rpm-tmp.mHe7cJ (%install)
RPM build errors:
Child return code was: 1


I suspect that this is because you are fixing the line endings in %build after
"make". You should fix line endings and make other source changes in %prep
where possible, which would avoid this problem. Also I think only the README
file actually needs its line-endings fixed anyway, so there's no need to touch
the other files.

It's usual practice now to use DESTDIR rather than PERL_INSTALL_ROOT when
installing.

Consider adding buildreqs for Perl core modules used by the module and its test
suite: Exporter, FileHandle, strict, File::Spec, Cwd and Test.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.