[Bug 794783] Review Request: xorg-x11-drv-modesetting - X.org modesetting fallback driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=794783

Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |xavier at bachelot.org
               Flag|                            |fedora-review?

--- Comment #4 from Xavier Bachelot <xavier at bachelot.org> 2012-02-17 16:56:23 EST ---
There are a couple missing BuildRequires:
BuildRequires: libX11-devel
BuildRequires: libdrm-devel
BuildRequires: libXext-devel

Also, there are a rpmlint warnings that need fixing, I've stripped the
irrelevant ones :
xorg-x11-drv-modesetting.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line
6, tab: line 3)
xorg-x11-drv-modesetting.x86_64: W: incoherent-version-in-changelog 0.1.0-0
['0.1.0-1.fc17', '0.1.0-1']

Not a big deal, but you should add a changelog entry and bump the release each
time you make changes to the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.