[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=789660

--- Comment #6 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> 2012-02-18 03:18:38 EST ---
Here is the explanation of the error,

In configure script generated by autoconf, there is a variable called
program_transform_name initialized to s,x,x. This variable is intended to be
passed to sed to modify the executable name. While doing a ./configure, if the
user passes --program-prefix=xyz, then the program_transform_name is modified
as s,^,xyz. And if we do not pass --program-prefix at all, it takes the default
(s,x,x). Now the makefile which is using this variable should not be affected
if  --program-prefix is not passed at all.

>From rpmbuild, calling %configure expands to ./configure <someoptions>
--program-prefix= .Since an empty prefix is passed,  program_transform_name
gets assigned to s&^&&. The makefile that uses the program_transform_name
variable encounters the command substitution error.

It is not necessary have to use program_transform_name variable in the Makefile
because configure is passing a empty prefix anyway. I have created a patch that
modifies the makefile to just copy the binaries into the destination
directories instead of trying to use the program_transform_name variable.


Spec file:
http://narasim.fedorapeople.org/package_reviews/xcftools.spec

Srpm file:
http://narasim.fedorapeople.org/package_reviews/xcftools-1.0.7-4.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.