[Bug 598860] Review Request: httpd-itk - MPM Itk for Apache HTTP Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598860

--- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> 2012-02-18 10:19:30 EST ---
Firstly thank you for the review, Nikos.

(In reply to comment #13)
> Actually you're using tabs instead of spaces :) And in some cases you're mixing
> them.
I believe it is not. Please say on what line and I'll fix it. Rpmlint silent
about that.

> Add some descriptive comments or/and upstream links on patches
> https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

It there. I have slightly fix it and add URL on comment.
> 
> You could add  build requires dependencies one per line. It's more readable.
It then increase size of file which already not so small. I think it is not
block.
> 
> Use the full length of a line for description, up to 80 characters.
There no lines longer already.

> I'm not sure it's a good idea to add an echo command on %install section. If
> you want to give some information to the user, better add a README.Fedora or
> add some info on description.
I have no any serious advantages of it, but it moved.

Also update to new version:
http://hubbitus.info/rpm/Fedora16/httpd-itk/httpd-itk.spec
http://hubbitus.info/rpm/Fedora16/httpd-itk/httpd-itk-2.2.22-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.