[Bug 794542] Review Request: dpsearch - DataparkSearch Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=794542

--- Comment #7 from Kevin Fenzi <kevin at scrye.com> 2012-02-18 12:42:03 EST ---
Minor nit:

The dpsearch.conf apache file will have different paths depending on 32bit or
64bit build. Might make sense to construct this in the spec file at build time?
Or comment in it that the path will be one or the other. 

1. You should rm the .la and .a files created. In most cases we don't want to
ship static libs or libtool archive files. 

2. The cgi's are now in the devel subpackage. That doesn't seem optimal.
Perhaps we should just let them stay in /usr/bin/ ?

3. rpmlint now says (if we filter the fsf-address thing): 

Man pages aren't required, so we can ignore this: 

dpsearch.i686: W: no-manual-page-for-binary dpconv
dpsearch.i686: W: no-manual-page-for-binary splitter
dpsearch.i686: W: no-manual-page-for-binary cached
dpsearch.i686: W: no-manual-page-for-binary run-splitter
dpsearch.i686: W: no-manual-page-for-binary indexer
dpsearch.i686: W: no-manual-page-for-binary searchd
dpsearch.i686: W: no-manual-page-for-binary stored
dpsearch.i686: W: no-manual-page-for-binary dpguesser

You can fix this by using %% 

dpsearch.src:53: W: macro-in-comment %{_prefix}

This is just due to googlecode being stupid. 

dpsearch.src: W: invalid-url Source0:
http://dataparksearch.googlecode.com/files/dpsearch-4.54-2012-02-15.tar.bz2
HTTP Error 404: Not Found
dpsearch.x86_64: W: no-manual-page-for-binary dpconv
dpsearch.x86_64: W: no-manual-page-for-binary splitter
dpsearch.x86_64: W: no-manual-page-for-binary cached
dpsearch.x86_64: W: no-manual-page-for-binary run-splitter
dpsearch.x86_64: W: no-manual-page-for-binary indexer
dpsearch.x86_64: W: no-manual-page-for-binary searchd
dpsearch.x86_64: W: no-manual-page-for-binary stored
dpsearch.x86_64: W: no-manual-page-for-binary dpguesser

You should make the devel subpackage require the base package by
version-release: 

dpsearch-devel.i686: W: no-dependency-on dpsearch/dpsearch-libs/libdpsearch

Nuke the . :) 

dpsearch-devel.i686: W: summary-ended-with-dot C Development files for the
DataparkSearch Engine.
dpsearch-devel.i686: W: no-documentation
dpsearch-devel.x86_64: W: no-dependency-on dpsearch/dpsearch-libs/libdpsearch
dpsearch-devel.x86_64: W: summary-ended-with-dot C Development files for the
DataparkSearch Engine.
dpsearch-devel.x86_64: W: no-documentation

All other issues look good. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.