[Bug 794980] Review Request: zanshin - Todo/action management software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=794980

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Rex Dieter <rdieter at math.unl.edu> 2012-02-19 05:00:07 EST ---
$ rpmlint zanshin zanshin-debuginfo
zanshin.x86_64: W: spelling-error Summary(en_US) Todo -> Tod, Toto, Todd
zanshin.x86_64: W: no-manual-page-for-binary zanshin
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Sources verified ok:
$ md5sum *.bz2
e8c920f07374cb08200f990ef592938c  zanshin-0.2.1.tar.bz2
17aba8cc59971622183cce67a74597b9  zanshin-lang.tar.bz2

Naming: ok

1.  SHOULD.  You have several dependencies listed explicitly that are already
pulled in implicitly by other stuff, you can drop
# kdelibs-devel already Requires: cmake
BuildRequires:  cmake
# kdelibs/kde-runtime already Requires oxygen-icon-theme
Requires:       oxygen-icon-theme

2.  SHOULD add a versioned runtime dep:
Requires: kdebase-runtime%{?_kde4_version: >= %{_kde4_version}}

3.  SHOULD.  macros/scriptlets mostly ok, but I'd recommend replacing all
%{_datadir}/icons
(use in scriptlets)
with
%{_kde4_iconsdir}

4.  SHOULD remove 
BuildRequires: intltool
as it's not needed or used as far as I can tell.

5.  MUST, looks like licensing is:

# KDE e.V. may determine that future GPL versions are accepted is
License: GPLv2

this is the convention (including the comment) we've been told by spot to use
when sources include the phrase (as-is here):
   This program is free software; you can redistribute it and/or
   modify it under the terms of the GNU General Public License as
   published by the Free Software Foundation; either version 2 of
   the License or (at your option) version 3 or any later version
   accepted by the membership of KDE e.V. (or its successor approved
   by the membership of KDE e.V.), which shall act as a proxy
   defined in Section 14 of version 3 of the license.

note that there are also indeed several sources that are LGPLv2+, but they are
combined and linked with the above, so the aggregate license really is GPLv2

6.  SHOULD use
%find_lang %{name} --with-kde
which will pick up any khelpcenter documentation handbook automatically if/when
it's ever included.


The rest looks fairly straight-forward and simple.


APPROVED.

I'll leave it to you to at least adjust the licensing MUST prior to doing any
official builds.  The should items are all optional, but recommended. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.