[Bug 784603] Review Request: python-messaging - abstraction of a "message"

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 20 09:37:53 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784603

--- Comment #11 from massimo.paladin at gmail.com 2012-02-20 04:37:53 EST ---
Steve,

some comments/questions before making the changes.

(1) I am gonna change python-simplejson dependency, it is required only for
python < 2.6

This if:
%if 0%{?fedora} > 12 || 0%{?rhel} > 6
%global with_python3 1
%else
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print (get_python_lib())")}
%endif
is coming from http://fedoraproject.org/wiki/Packaging:Python , may be that
should be changed.

(2) URL was coming from a copy & paste of the README file, will change that

(3) again, this appears in http://fedoraproject.org/wiki/Packaging:Python ,
shall it be mentioned in that page?

(4) with mock and EPEL5 looks fine so I don't think it needs to be changed,
right?
$ rpm -qp --requires
/var/lib/mock/epel-5-x86_64/result/python-messaging-0.5-1.el5.centos.noarch.rpm 
python(abi) = 2.4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list