[Bug 787738] Review Request: wss4j - Apache WS-Security implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787738

--- Comment #2 from Andy Grimm <agrimm at gmail.com> 2012-02-20 09:52:26 EST ---
> I presume you chose version 1.5 over 1.6 so you could patch out the opensaml
> dependency.  Any idea how long 1.5 will have upstream support?

Version 1.5.x uses OpenSAML 1.x, and Version 1.6.x uses OpenSAML 2.x,and while
that doesn't impact this build, it probably impacts upgrade for some people and
will prolong the life of 1.5.x.  There is still a "1_5_x-fixes" branch, which
has commits as recent as December.  I expect that we'll move to 1.6 in Fedora
18, as we have time to package more dependencies.

> The spec file has only a few minor issues:
> - ™ must not appear in package descriptions

Fixed.

> - Patch entries in the spec file need descriptive comments

Comments added.

> - The java dep must be versioned per the java guidelines

I don't see this in the current java guidelines, and I suspect that it would
only mislead people.  Use of Fedora 17 implies JDK 7, but compiling with an
older JDK for an older distro is certainly valid.

> - You need to add post and postun deps on jpackage-utils per the java
guidelines

Again, current java guidelines don't include this; in fact, it's forbidden:
https://fedoraproject.org/wiki/Java_review_template

SPEC:
http://downloads.eucalyptus.com/devel/packages/fedora-17/SPECS/wss4j.spec

SRPM:
http://downloads.eucalyptus.com/devel/packages/fedora-17/sources/wss4j-1.5.12-2.fc17.src.rpm


Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.