[Bug 791263] Review Request: mockito - A Java mocking framework

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 21 22:29:58 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=791263

--- Comment #14 from Marcin Zajaczkowski <mszpak at wp.pl> 2012-02-21 17:29:57 EST ---
I've been using Mockito for years and generally it's not a problem. If you
would like to use MockitoJUnitRunner in your code then you have to add JUnit
dependency to your project anyway to use JUnit itself (e.g. in tests that
doesn't use Mockito). With TestNG it doesn't make sense to use JUnit runner and
you don't reference to those classes in your code (mocks can be also
initialized using MockitoAnnotations.initMocks()).

I would treat JUnit as an optional dependency (a little bit like a plugin which
could be enabled if a library/jar is provided). If the end user (some
application) needs JUnit then it has to add it manually as a dependency. If
uses TestNG or something else there is no side effects. I would leave
BuildRequires - it's required to build Mockito itself.

It is from a Java programmer point of view. I've never packaged Java based
application for Fedora. You can ask Szczepan and others on the mailing list,
but I doubt that JUnit would be added as a required dependency. I would force
non-junit users to excluded it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list