[Bug 795696] Review Request: sc - A script collection to go from minimal install to GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=795696

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2012-02-22 16:51:49 EST ---
Some comments:

 - what GPL version is correct? 2, 2+, 3, 3+ or something else?

 - Prefix:     /usr/share/sc
   please don't do this, to easy to confuse with %{_prefix}
   define e.g %{schome} by 

   %global schome %{_datadir}/sc

 - keep line width < 78 chars

 - %defattr(-,root,root,0755) leave that to %defattr(-,root,root,-)
   and set correct perms on files in %install

 - %files is too complicated, with change above this is enough:

   %{schome}

 - sc-readme and changelog should be located in /usr/share/doc/sc-$version,
   use %doc macro for this.

 - write proper %changelog.

You might want to create FAS account and do a koji scratch build.

Any rpmlint output?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.