[Bug 225708] Merge Review: dovecot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225708

Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |paul at city-fan.org

--- Comment #20 from Paul Howarth <paul at city-fan.org> 2012-02-23 07:49:01 EST ---
Some comments from comparing the built packages with my local build (see
http://www.city-fan.org/cfo-trac/browser/dovecot/trunk):

You could include /var/run/dovecot, /var/run/dovecot/login and
/var/run/dovecot/empty as regular (not %ghost) directories in the package and
add entries for the latter two directories in the tmpfiles.d config file. There
would no longer be any need then to create/chown/restorecon those directories
in %post, and an rpm query for ownership of the directories would give the
proper answer.

The main package contains %_libexecdir/dovecot/managesieve and
%_libexecdir/dovecot/managesieve-login, which are duplicates of the ones in the
pigeonhole package.

The main package contains %_libdir/dovecot/lib90_sieve_plugin.so, which should
be (but isn't) in the pigeonhole package.

Perhaps the main package should own the %_libdir/dovecot/settings directory in
case any package other than the pigeonhole one wanted to drop files in there in
the future?

I have a Requires(post) for openssl for the mkcert.sh script but I guess that's
covered by the Requires: openssl anyway?

The Requires(post) and Requires(preun) of chkconfig are not needed for
systemd-based releases.

The Requires(post) and Requires(preun) of shadow-utils are not needed at all.

The Requires(preun) of initscripts is not needed for systemd-based releases.

Perhaps install the pigeonhole documentation into directory
%_docdir/dovecot-pigeonhole-2.1.0 as per the rpm package name/version rather
than %_docdir/dovecot-2.1-pigeonhole-0.3.0 as per upstream naming?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.