[Bug 673790] Rename Request: mingw32-w32api -> mingw-headers - Win32/Win64 header files and stubs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673790

Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #14 from Kalev Lember <kalevlember at gmail.com> 2012-02-25 15:45:46 EST ---
Fedora review of mingw-headers-2.0.999-0.4.trunk.20120224.fc18_cross.src.rpm
2012-02-25

+ OK
! needs attention

rpmlint output:

$ rpmlint mingw-headers-2.0.999-0.4.trunk.20120224.fc16.src.rpm \
          mingw32-headers-2.0.999-0.4.trunk.20120224.fc16.noarch.rpm \
          mingw64-headers-2.0.999-0.4.trunk.20120224.fc16.noarch.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license files (COPYING DISCLAIMER DISCLAIMER.PD
COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  1223b8f402e1e6296c5b70d63b37d4b0  mingw-w64-src_20120224.tar.bz2
  1223b8f402e1e6296c5b70d63b37d4b0  Download/mingw-w64-src_20120224.tar.bz2
+ The package builds on primary architectures
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file must handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
  Not applicable to MinGW packages.
n/a Static libraries must be in -static
n/a Development files must be in a -devel package
  Not applicable to MinGW packages.
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
+ Proper Obsoletes / Provides for replacing mingw32-w32api

A minor nit about the source package summary "Win32/Win64 header files and
stubs" -- this package doesn't actually contain the stubs for linking with the
MS provided dll files; the stubs are all in mingw-crt.

Also, the required mingw32-filesystem version is different in Requires and
BuildRequires (65 vs 70), might want to use the same number to avoid confusion.

Otherwise looks good.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.