[Bug 798200] Review Request: dbus-cli - DBus console client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798200

Jaroslav Reznik <jreznik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #1 from Jaroslav Reznik <jreznik at redhat.com> 2012-02-28 09:33:19 EST ---
Name: not ok, the upstream project is called dbus-tools, shouldn't be better to
use it as well? as dbus-tools is a set of dbus-cli and zsh autocompetition,
personally I prefer dbus-tools
Version: not ok, version should be 0
Release: not ok, should be 0.1.20120227svn, you don't have to add revision as
it's commented in sources part
License: ISC, ok
URL: ok
Sources: SVN snapshot, ok, correct description to get the source codes
BuildArch: ok
BuildRequires: not ok, missing python2-devel according to package guidelines
for Python
Requires: not ok, python(abi) >= 2.7, python(abi) < 3.0 has to be removed
Description: ok but should be updated - dcop section is not correct anymore
Macros used consistently: ok
Documentation: ok

rpmlint dbus-cli-20120227svn8-1.fc16.src.rpm 
dbus-cli.src: W: spelling-error %description -l en_US dcop -> cop, drop, d cop
- ok
dbus-cli.src: W: invalid-url Source0: dbus-cli-20120227.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
- svn snapshot

Scratch build: ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=3827843

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.