[Bug 717337] Review Request: URCU - Userspace RCU Implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717337

--- Comment #12 from Bill Nottingham <notting at redhat.com> 2012-02-28 13:13:42 EST ---

- Package meets naming and packaging guidelines ***

Upstream tarball is named userspace-rcu. Package is named liburcu.

I'm inclined to let it go, though.

- Spec file matches base package name. - OK
- Spec has consistant macro usage.  - OK
- Meets Packaging Guidelines. - OK
- License - LGPLv2+
- License field in spec matches - OK
- License file included in package - ***

License file (LICENSE) isn't in package's %doc.

- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum:  - OK
a455ea20ca7fc4f259f7b7fd92f0e975da8f0f19  userspace-rcu-0.6.5.tar.bz2

- Package needs ExcludeArch - has it for mips, which we don't support -> OK
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is relocatable and has a reason to be. - N/A
- Package has %defattr and permissions on files is good. ***

Permissions are fine. %defattr not included, not needed unless you're
backporting to older ELs.

- Package has a correct %clean section. ***

%clean not included, but not needed unless you're backporting to older ELs.

- Package is code or permissible content. - N/A
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK

- Headers/static libs in -devel subpackage. - OK
- Spec has needed ldconfig in post and postun - OK
- .pc files in -devel subpackage/requires pkgconfig - ***

liburcu-devel should have Requires: pkgconfig

- .so files in -devel subpackage. - OK
- -devel package Requires: %{name} = %{version}-%{release}  - OK
- .la files are removed. - OK

- Package compiles and builds on at least one arch. - OK (tested x86_64)
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - ***

Package should own %{includedir}/urcu

- No rpmlint output.

liburcu.x86_64: W: spelling-error Summary(en_US) Userspace -> User space,
User-space, Users pace
Can be ignored (can also be fixed if you're bored).

liburcu.x86_64: W: shared-lib-calls-exit /usr/lib64/liburcu.so.1.0.0
exit at GLIBC_2.2.5

Does not need fixed, but can be impolite.

- final provides and requires are sane: - OK, modulo pkgconfig item above

SHOULD Items:

- Should build in mock. - OK
- Should build on all supported archs - tested x86_64
- Should function as described. - didn't test
- Should have sane scriptlets. - OK
- Should have subpackages require base package with fully versioned depend. -
OK
- Should have dist tag - OK
- Should package latest version  ***

Latest is 0.6.7.

Issues:

1. Package license file
2. liburcu-devel should have Requires: pkgconfig
3. Package should own %{includedir}/urcu
4. Should upgrade to 0.6.7.
5. %defattr/%clean can be included if you want, but not required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.