[Bug 790628] Review Request: Adobe Source Libraries - General Purpose Addon for Boost and STL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790628

--- Comment #20 from Alec Leamas <leamas.alec at gmail.com> 2012-02-29 11:28:12 EST ---
(In reply to comment #19)
[cut]

Upstream is basically silent. There are a large number of patches available,
but nothing seem to be merged or otherwise commented. Given the nature of the
file, I have decided to leave it. After all, this is documentation, not
configuration or code.

> Note that this is usually removed in %prep unless there is something legally
> troubling with it. Although it isn't explicitly required and since it
> dramatically reduces the size of the source, I would see it as acceptable.
Agreed. There are other reasons as well: spec simplicity, a reasonable way to
handle those perforce repositories.

> 
> > - jamroot is patched to not include other references to boost source.
> 
> Is this the asl-fedora-flags.patch or is it one of the sed/other lines? Not to
> nit pick, but it doesn't seem very clear in the spec file, in the name of the
> patch, or the comments.
It's in the asl-fedora-flags.patch. You are right, this need to be renamed.
BTW, this is a place for nit-picking, no need to apologize ;)

> Also, what is source2? It doesn't seem to be mentioned in the commenting
Well, the .pc extension basically says it all: it's a pkg-config configuration
file, used by other packages to figure out flags required to build using this
lib. This is a (the?) standard mechanism for C libraries. Should I comment it?

Although the patch needs to be renamed, I'm not publishing new links at this
point.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.