[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771111

--- Comment #7 from Steven Dake <sdake at redhat.com> 2012-01-01 12:20:52 EST ---
Ofer,

I am a packager and can provide reviews of other packagers packages, but you
need a Sponsor (see
https://admin.fedoraproject.org/accounts/group/members/packager/*/sponsor for a
list of sponsors) to provide the review so that you can eventually make it into
the packagers group (this allows people in the "Packagers" group to review your
packages).

Lets get started to help the sponsor out a bit.

The tarball is constructed incorrectly.  There should only be a directory in
the top level of the tarball.

instead of:

-rw-rw-r-- oschreib/oschreib 343 2011-12-15 06:49 .gitignore
-rw-rw-r-- oschreib/oschreib 364 2011-12-15 06:49 .project
-rw-rw-r-- oschreib/oschreib 426 2011-12-15 06:49 .pydevproject
-rw-rw-r-- oschreib/oschreib 103 2011-12-15 06:49
.settings/org.eclipse.core.res
ources.prefs
-rw-rw-r-- oschreib/oschreib  99 2011-12-15 06:49 AUTHORS
-rw-rw-r-- oschreib/oschreib 123 2011-12-15 06:49 MANIFEST.in
-rw-rw-r-- oschreib/oschreib 1008 2011-12-27 07:51 Makefile
-rw-rw-r-- oschreib/oschreib 1760 2011-12-15 06:49 README
-rw-rw-r-- oschreib/oschreib 1577 2012-01-01 09:34 ovirt-engine-sdk.spec.in
-rw-rw-r-- oschreib/oschreib 2089 2011-12-15 06:49 parser_lex.py
-rw-rw-r-- oschreib/oschreib 10274 2011-12-15 06:49 parser_tab.py
-rw-rw-r-- oschreib/oschreib   925 2011-12-27 07:51 setup.py
-rw-rw-r-- oschreib/oschreib   529 2012-01-01 06:06
src/ovirt_engine_sdk.egg-inf
o/PKG-INFO

It should be something like:

/ovirt-engine-sdk/All those files

The tarball files should not have group writeable permissions.  

I assume this problem occurs because upstream hasn't made a release of the
software.  Provide feedback to upstream to ensure the release process produces
correct tarballs.

This will allow you to remove the lines:

%{__install} -p -m 644 AUTHORS %{buildroot}%{_defaultdocdir}/%{name}/
%{__install} -p -m 644 README %{buildroot}%{_defaultdocdir}/%{name}/

And change:
%doc %{_defaultdocdir}/%{name}/AUTHORS
%doc %{_defaultdocdir}/%{name}/README

to 
%doc AUTHORS
%doc README

It is generally frowned upon to put upstream repository snapshots in Fedora. 
Encourage upstream to make a tarball release.  This may be a blocker issue for
the Sponsor reviewer (I am not certain on this point).

Please adjust the spec and rpm as per this message and then I'll walk through
list of review MUST and SHOULDs.

Regards
-steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.