[Bug 738590] Review request: rubygem-gettext_i18n_rails - Simple FastGettext Rails integration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738590

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Vít Ondruch <vondruch at redhat.com> 2012-01-02 10:02:07 EST ---
rpmlint reports following warning:

rubygem-gettext_i18n_rails.src: W: strange-permission
rubygem-gettext_i18n_rails.spec 0666L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

* Please consider removing of "Requires: rubygem(gettext)", since it is rails
  application development dependency, not a runtime think.
* Similarly "Requires: rubygem(ruby_parser)" should be removed for the same
  reason. Unfortunately, this dependency is now enforced by upstream. I have
  already opened issue [1] because of this.

Nevertheless, since these are just minor nits, I APPROVE the package. Please
fix them before commit if possible.


[1] https://github.com/grosser/gettext_i18n_rails/issues/49

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.