[Bug 770721] Review Request: substance - Swing look-and-feel library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770721

--- Comment #5 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-01-03 06:49:01 EST ---
I'm unable to reproduce your bug. I think the source archive you downloaded is
corrupted. Delete it and try to retrieve it again using this command:
   $ spectool -g substance.spec -C ../SOURCES/

By the way, be very careful with the formatting of the changelog; be sure to
use for each entry  the following pattern:
    * DATE AUTHOR <EMAIL> VERSION-RELEASE
     - COMMENT1
     - COMMENT2
     - ...
Don't use also macros in changelog, unless you escape them using %:
    - added %{_javadir]/* to files section →    - added %%{_javadir}/* to files
section

You'd better put the Git commit ID in a macro, in case substance is updated:
   # Git commit ID corresponding to the current version of substance
   %global commit  58d3873

   Name:  substance
   Version:         6.0
   ...
   Source0:
https://github.com/kirillcool/%{name}/zipball/master/kirillcool-%{name}-%{commit}.zip
   ...
   %prep
   %setup -q -n kirillcool-%{name}-%{commit}
   ...

The most important thing is that substance embeds dependencies libs, as for
TV-Browser. You must delete them before building and rely on those provided by
the Fedora repos. To help you, here is the list of the embedded jar files and
the corresponding Fedora package providing it, if available:
   trident.jar → not available, must be packaged
(http://kenai.com/projects/trident/pages/Home)
   forms-1.2.0.jar → jgoodies-forms
   laf-plugin.jar → laf-plugin
   asm-all-2.2.2.jar → objectweb-asm
   laf-widget.jar → not available, must be packaged
(http://java.net/projects/laf-widget/s)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.