[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=759757

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2012-01-05 07:58:41 EST ---
Source tar ball is original. Ok.
Summary verified from EUCJPASCII.pm. Ok.
Description verified from EUCJPASCII.pm. Ok.

Note: I'm not sure `eucJP-ascii' and `eucJP-open' are properly capitalized.
Different texts use different capitalization and hyphenation. Let's hope イケダソジ,
author of this module, knows better.

License verified from EUCJPASCII.pm. Ok.
URL and Source0 values are useful. Ok.

TODO: Remove useless BuildRoot definition, it's cleaning in %install section,
and whole %clean section. They are not needed anymore.

TODO: Build-require perl(Encode) for tests (EUCJPASCII.pm:6)
TODO: Build-require perl(XSLoader) for tests (EUCJPASCII.pm:7)
TODO: Build-require perl(base) for tests (EUCJPASCII.pm:18)
TODO: Build-require perl(Encode::CJKConstants) for tests (EUCJPASCII.pm:23)
TODO: Build-require perl(Encode::JP::JIS7) for tests (EUCJPASCII.pm:23)

FIX: Build-require perl(File::Spec) (Makefile.PL:18)

All tests pass. Ok.

TODO: Remove useless %defattr from %files section.

$ rpmlint perl-Encode-EUCJPASCII.spec
../SRPMS/perl-Encode-EUCJPASCII-0.03-1.fc17.src.rpm
../RPMS/x86_64/perl-Encode-EUCJPASCII-*
perl-Encode-EUCJPASCII.src: W: spelling-error Summary(en_US) eucJP -> eggcup,
equip, uncap
perl-Encode-EUCJPASCII.src: W: spelling-error %description -l en_US eucJP ->
eggcup, equip, uncap
perl-Encode-EUCJPASCII.src: W: spelling-error %description -l en_US ascii ->
ASCII, ASCIIs, As
perl-Encode-EUCJPASCII.x86_64: W: spelling-error Summary(en_US) eucJP ->
eggcup, equip, uncap
perl-Encode-EUCJPASCII.x86_64: W: spelling-error %description -l en_US eucJP ->
eggcup, equip, uncap
perl-Encode-EUCJPASCII.x86_64: W: spelling-error %description -l en_US ascii ->
ASCII, ASCIIs, As
perl-Encode-EUCJPASCII.x86_64: E: zero-length
/usr/lib64/perl5/vendor_perl/auto/Encode/EUCJPASCII/EUCJPASCII.bs
3 packages and 1 specfiles checked; 1 errors, 6 warnings.

FIX: Remove empty *.bs files. (These empty bootstrap files for DynaLoader are
useless.)

$ rpm -q -lv -p ../RPMS/x86_64/perl-Encode-EUCJPASCII-0.03-1.fc17.x86_64.rpm 
drwxr-xr-x    2 root    root                        0 Jan  5 13:40
/usr/lib64/perl5/vendor_perl/Encode
-rw-r--r--    1 root    root                     5662 Oct 19  2009
/usr/lib64/perl5/vendor_perl/Encode/EUCJPASCII.pm
drwxr-xr-x    2 root    root                        0 Jan  5 13:40
/usr/lib64/perl5/vendor_perl/auto
drwxr-xr-x    2 root    root                        0 Jan  5 13:40
/usr/lib64/perl5/vendor_perl/auto/Encode
drwxr-xr-x    2 root    root                        0 Jan  5 13:40
/usr/lib64/perl5/vendor_perl/auto/Encode/EUCJPASCII
-rw-r--r--    1 root    root                        0 Jan  5 13:40
/usr/lib64/perl5/vendor_perl/auto/Encode/EUCJPASCII/EUCJPASCII.bs
-rwxr-xr-x    1 root    root                   759816 Jan  5 13:40
/usr/lib64/perl5/vendor_perl/auto/Encode/EUCJPASCII/EUCJPASCII.so
drwxr-xr-x    2 root    root                        0 Jan  5 13:40
/usr/share/doc/perl-Encode-EUCJPASCII-0.03
-rw-r--r--    1 root    root                      569 Oct 19  2009
/usr/share/doc/perl-Encode-EUCJPASCII-0.03/Changes
-rw-r--r--    1 root    root                      496 Oct 19  2009
/usr/share/doc/perl-Encode-EUCJPASCII-0.03/README
Files permissions and layout are Ok.

$ rpm -q --requires -p
../RPMS/x86_64/perl-Encode-EUCJPASCII-0.03-1.fc17.x86_64.rpm |sort |uniq -c
      1 libc.so.6()(64bit)  
      1 libc.so.6(GLIBC_2.2.5)(64bit)  
      1 perl(base)  
      1 perl(bytes)  
      1 perl(Encode)  
      1 perl(Encode::CJKConstants)  
      1 perl(Encode::Encoding)  
      1 perl(Encode::JP::JIS7)  
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(strict)  
      1 perl(warnings)  
      1 perl(XSLoader)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)  
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/x86_64/perl-Encode-EUCJPASCII-0.03-1.fc17.x86_64.rpm |sort |uniq -c
      1 perl(Encode::EUCJPASCII) = 0.03
      1 perl-Encode-EUCJPASCII = 0.03-1.fc17
      1 perl-Encode-EUCJPASCII(x86-64) = 0.03-1.fc17
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/x86_64/perl-Encode-EUCJPASCII-0.03-1.fc17.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3621985). Ok.

Otherwise package is in line with Fedora and Perl packaging guidelines.


Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and
provide new spec file.

Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.