[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770986

Mamoru Tasaka <mtasaka at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Mamoru Tasaka <mtasaka at fedoraproject.org> 2012-01-05 23:25:33 EST ---
Sorry for being late.

For -3:

* %install vs %check
  - build.log shows:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=3623729
    http://koji.fedoraproject.org/koji/getfile?taskID=3623730&name=build.log
--------------------------------------------------------
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.SHK0hf
+ umask 022
...
...
+ RUBYOPT='-Ilib
-I/builddir/build/BUILDROOT/rubygem-kgio-2.7.0-3.fc17.x86_64/usr/lib64/ruby/site_ruby/1.8/x86_64-linux
-Itest'
+ testrb test/test_accept_class.rb test/test_accept_flags.rb ...
...
...
255 tests, 132826 assertions, 0 failures, 0 errors
+ rm -f
/builddir/build/BUILDROOT/rubygem-kgio-2.7.0-3.fc17.x86_64/usr/lib/ruby/gems/1.8/gems/kgio-2.7.0/.document
+ rm -f
/builddir/build/BUILDROOT/rubygem-kgio-2.7.0-3.fc17.x86_64/usr/lib/ruby/gems/1.8/gems/kgio-2.7.0/.gitignore
....
-------------------------------------------------------

    So now the lines from "rm -rf %{buildroot}%{geminstdir}/.document" to
    "mv %{buildroot}%{geminstdir}/lib/kgio_ext.so 
        %{buildroot}%{ruby_sitearch}"
    are now executed on %check (because on the spec file"%check" is written
    above). 
    Please move the lines
--------------------------------------------------------
 %check
# Patch test_autopush.rb
cd %{buildroot}%{geminstdir}
RUBYOPT="-Ilib -I%{buildroot}%{ruby_sitearch} -Itest" testrb test/test_*
--------------------------------------------------------
    to below "mv %{buildroot}%{geminstdir}/lib/kgio_ext.so ..." line (and above
    %clean section).

Please fix the above issue before importing this package
into Fedora git.

--------------------------------------------------------
  This package (rubygem-kgio) is APPROVED by mtasaka
--------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.