[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771851

--- Comment #2 from Bohuslav Kabrda <bkabrda at redhat.com> 2012-01-06 05:02:32 EST ---
- BuildRequires: python-devel should be BuildRequires: python2-devel, see [1].
- When packaging for Fedora 13 or greater, you don't need to define
%python_sitelib yourself, because its in a macro file in python2-devel, see
[2].
- Could you please specify why you need the two identical files in %{_bindir},
only with different names? It is an upstream decision, but maybe you could
query them about this?
- The package seems to have a bundled library python-chardet, which is already
in Fedora. You should unbundle it and make the Fedora package runtime
dependency. (Perhaps query the upstream not to bundle it at all?)
- You probably don't need to use the CFLAGS in %build section, as your package
doesn't contain any binary extensions.
- "rm -rf $RPM_BUILD_ROOT" is not needed, if you don't plan on getting the
package to EPEL.
- Could you please clarify the LICENSE? Your specfile says GPLv2+, but PKG-INFO
only says GPL.

[1] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[2] https://fedoraproject.org/wiki/Packaging:Python#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.