[Bug 771137] Review Request: decibel-audio-player - straightforward music player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771137

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> 2012-01-08 01:47:08 EST ---
Just some comments:

- Drop defattr, it is no longer necessary
- If you don't go for EPEL 5, you can drop the buildroot definition, the clean
section and the rm in the install section
- Consider using a loop to create directories and install the icons


%{_datadir}/%{name}

could replace

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/pix
%{_datadir}/%{name}/res
%{_datadir}/%{name}/src

as far as I can see


- The RPM changelog is intended for changes in packaging, not within the
software
- Man pages should not be marked as documentation
- Was "vendor" used in desktop files in older versions of this package? If not,
it should not be used.
- Consider harmonizing the style of your sed invocations

I'm not sure about those shell scripts that act as starters. Are they really
necessary?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.