[Bug 772217] Review Request: libyuv - YUV conversion and scaling functionality library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772217

--- Comment #2 from Brendan Jones <brendan.jones.it at gmail.com> 2012-01-08 08:37:33 EST ---
Formal review still pending, but here's a few comments for your review:

- %defattr(-, root, root) no longer required rpmbuild >= 4.4 See
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

- BuildRoot tag and clean sections only required for EPEL 5 and under See
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- Mixed use of macros $RPM_BUILD_ROOT and %buildroot

- Also to to provide explicit requires on the devel package to the base
package. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


rpmlint output mostly OK, just the W: spelling-error %description, W:
unused-direct-shlib-dependency and W: summary-not-capitalized need reviewing

bsjones at f15laptop SPECS$rpmlint /home/bsjones/rpmbuild/RPMS/x86_64/libyuv-*
libyuv.x86_64: W: spelling-error %description -l en_US webcam -> web cam,
web-cam, became
libyuv.x86_64: W: spelling-error %description -l en_US bilinear -> bi linear,
bi-linear, linear
libyuv-devel.x86_64: W: summary-not-capitalized C development files for libyuv
libyuv-devel.x86_64: W: spelling-error %description -l en_US Asdditional ->
Additional, Traditional, Conditional
libyuv-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

bsjones at f15laptop SPECS$rpmlint libyuv
libyuv.x86_64: W: spelling-error %description -l en_US webcam -> web cam,
web-cam, became
libyuv.x86_64: W: spelling-error %description -l en_US bilinear -> bi linear,
bi-linear, linear
libyuv.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyuv.so.0.0.0
linux-vdso.so.1
libyuv.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyuv.so.0.0.0
/usr/lib64/libstdc++.so.6
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
bsjones at f15laptop SPECS$rpmlint libyuv-devel
libyuv-devel.x86_64: W: summary-not-capitalized C development files for libyuv
libyuv-devel.x86_64: W: spelling-error %description -l en_US Asdditional ->
Additional, Traditional, Conditional
libyuv-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.