[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #4 from Lubomir Rintel <lkundrak at v3.sk> 2012-01-09 09:15:13 EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Thank you for your suggestions. Here are the updated packages:
> > 
> > SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
> > SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm
> > 
> > (In reply to comment #1)
> > > I think the package summary does not describe the package very well. The
> > > description gave me a completely different view.
> > 
> > What view did it give you? I can't really think of a better description and
> > would appreciate help here.
> > 
> 
> The way you put it now sounds a lot better to me! :)

Oh, I reworded the summary. I thought you were referring to the description.

> > > Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
> > > the clean section, buildroot definition and the rm in the install section.
> > 
> 
> (Defattr is not necessary for EPEL 5 either.)

rpmlint whines then :(
Would you mind if I leave it there just to make el6 rpmlint (that I use) happy?

> > > The FSF address is outdated.
> > 
> > Changed that to <http://fsf.org>, which seems to be used in GPLv3.
> 
> No, I meant the postal address. They moved from Temple Place to Franklin Street
> in 2005.

Yes. The GPLv3 text does not include the postal address, just an URL, thus I
just leave just an URL here as well.

> I tried your software but messed up somehow. Let's see if I can get it working
> for me! :)

Let me know then please. Be sure not to skip manual's BUGS section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.