[Bug 756635] Review Request: gap - Computational discrete algebra

Tue Jan 10 21:59:17 UTC 2012

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=756635

Scott Tsai <scottt.tw at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Scott Tsai <scottt.tw at gmail.com> 2012-01-10 16:59:15 EST ---
Sorry for the delay for this review:
1. gap-core should own /usr/lib/gap/ (%{gaparchdir}) since it owns
/usr/lib/gap/sysinfo.gap

2. For gap-vim, since you're not shipping README.vim-utils I recommend you ship
the attached gap.vim as /usr/share/vimfiles/ftdetect/gap.vim. Otherwise the
user would have to know to manually ":set filetype=vim" to activate the VIM
sytnax hightlighting and indentation plugins.
Hopefully the *.g, *.gi, *.gd file extensions are not used by other file types.

3. Placing "README.fedora" in gap-libs and placing "description4r4p10" in
gap-core seems a bit strange to me. Maybe move "README" and "README.fedora" to
gap-core? (not critical)

4. Since Fedora packaging lack Debian's "recommand" and "suggest"
functionality, I'm not sure splitting out the prim, small and trans group
subpackages is really a good idea but I'll leave it to your disgression.

5. I was able to build and load the "Example" package from
http://www.gap-system.org/Packages/packages.html sucessfully.

Formal Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
rpmlit warnings and errors are all justified:

incorrect-fsf-address is not a bit deal
 rpmlint gap-libs-4.4.12-2.fc17.noarch.rpm

 gap-libs.noarch: E: incorrect-fsf-address /usr/share/doc/gap-libs-4.4.12/GPL
 1 packages and 0 specfiles checked; 1 errors, 0 warnings.

no-documentation is fine for gap-emacs-el
 rpmlint gap-emacs-el-4.4.12-2.fc17.noarch.rpm

 gap-emacs-el.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

/usr/lib/sysinfo.gap is non-binary and it's fine
 rpmlint gap-core-4.4.12-2.fc17.x86_64.rpm

 gap-core.x86_64: W: only-non-binary-in-usr-lib
 gap-core.x86_64: E: zero-length /var/lib/gap/workspace
 1 packages and 0 specfiles checked; 1 errors, 1 warnings.

Though gap.x86_64 is empty, it can't be noarch since it depends on gap-core.
Those are not really spelling errors.
no-documentation is fine for gap.
 rpmlint gap-4.4.12-2.fc17.x86_64.rpm

 gap.x86_64: W: spelling-error %description -l en_US combinatorial ->
combination
 gap.x86_64: W: spelling-error %description -l en_US metapackage -> meta
package, meta-package, prepackage
 gap.x86_64: E: no-binary
 gap.x86_64: W: no-documentation
 1 packages and 0 specfiles checked; 1 errors, 3 warnings.

no-documentation is fine for gap-prim-groups.
 rpmlint gap-prim-groups-4.4.12-2.fc17.noarch.rpm

 gap-prim-groups.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

no-documentation is fine for gap-prim-groups.
 gap-trans-groups.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

no-documentation is fine for gap-small-groups.
 rpmlint gap-small-groups-4.4.12-2.fc17.noarch.rpm

 gap-small-groups.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

no-documentation is fine for gap-vim.
 rpmlint gap-vim-4.4.12-2.fc17.noarch.rpm

 gap-vim.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

%{_prefix}/lib/gap is not really a harcoded-library-path.
update-gap-workspace having 0755 permissionin the src rpm is fine.
Those are not really spelling errors.
 rpmlint gap-4.4.12-2.fc17.src.rpm

 gap.src: W: spelling-error %description -l en_US combinatorial -> combination
 gap.src: W: spelling-error %description -l en_US metapackage -> meta package,
meta-package, prepackage
 gap.src: W: strange-permission update-gap-workspace 0755L
 gap.src:4: E: hardcoded-library-path in %{_prefix}/lib/gap
 1 packages and 0 specfiles checked; 1 errors, 3 warnings.

no-documentation is fine for gap-xemacs-el
 rpmlint gap-xemacs-el-4.4.12-2.fc17.noarch.rpm

 gap-xemacs-el.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

no-documentation is fine for gap-online-help
answers.tex being empty is a bit perculiar but it's like that in the upstream
tarball.
 rpmlint gap-online-help-4.4.12-2.fc17.noarch.rpm

 gap-online-help.noarch: W: no-documentation
 gap-online-help.noarch: E: zero-length /usr/share/gap/doc/tut/answers.tex
 1 packages and 0 specfiles checked; 1 errors, 1 warnings.

[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
update-gap-workspace :
  MD5SUM this package     : d4a980c11de9b52b865e1eb8922ee884
  MD5SUM upstream package : upstream source not found
gap.xml :
  MD5SUM this package     : ee18c6f9efe9bf6b505ecef15eb6f137
  MD5SUM upstream package : upstream source not found
/home/scottt/work/gap/gap4r4p12.tar.bz2 :
  MD5SUM this package     : 2808c00e85e98843bb0e1a62c33ad5f0
  MD5SUM upstream package : 2808c00e85e98843bb0e1a62c33ad5f0
gap-README.fedora :
  MD5SUM this package     : 678ca9de660d5fa489de82e4db9f7e8e
  MD5SUM upstream package : upstream source not found
gap.1.in :
  MD5SUM this package     : 92d1bc5e0acd996c650170bcb2583e35
  MD5SUM upstream package : upstream source not found
gac.1.in :
  MD5SUM this package     : 379c8943fdce42bdd8302420153b8d4f
  MD5SUM upstream package : upstream source not found
gap.desktop :
  MD5SUM this package     : a97be403c8b9aa74cc8cdea5488f9666
  MD5SUM upstream package : upstream source not found
gap.el :
  MD5SUM this package     : e28f5579433842bb3e73b1a8120bc72b
  MD5SUM upstream package : upstream source not found
update-gap-workspace.1 :
  MD5SUM this package     : e5644d608a5f88272a844d7867567fbd
  MD5SUM upstream package : upstream source not found

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SHOULD Scriptlets must be sane, if used.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source1: gap-README.fedora (gap-README.fedora) Source2: update-gap-
     workspace (update-gap-workspace) Source3: gap.xml (gap.xml) Source4:
     gap.desktop (gap.desktop) Source5: gap.el (gap.el) Source6: gap.1.in
     (gap.1.in) Source7: gac.1.in (gac.1.in) Source8: update-gap-workspace.1
     (update-gap-workspace.1) Patch0: gap-paths.patch (gap-paths.patch)
     Patch1: gap-raw.patch (gap-raw.patch) Patch2: gap-help.patch (gap-
     help.patch) Patch3: gap-crc.patch (gap-crc.patch) Patch4: gap-env.patch
     (gap-env.patch) Patch5: gap-alias.patch (gap-alias.patch) Patch6: gap-
     emacs.patch (gap-emacs.patch)
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

I'll approve this as soon as you fix points one and two above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.