[Bug 760943] Review Request: perl-Messaging-Message - This perl module provides an abstraction of a "message", as used in messaging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760943

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Petr Pisar <ppisar at redhat.com> 2012-01-12 08:33:13 EST ---
Spec file changes:

--- perl-Messaging-Message.spec 2012-01-09 11:47:43.000000000 +0100
+++ perl-Messaging-Message.spec.1       2012-01-12 10:23:25.000000000 +0100
@@ -1,6 +1,6 @@
 Name:          perl-Messaging-Message
 Version:       0.7
-Release:       1%{?dist}
+Release:        2%{?dist}
 Summary:       Abstraction of a message
 License:       GPL+ or Artistic
 Group:         Development/Libraries
@@ -9,20 +9,21 @@
 BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:     noarch
 BuildRequires: perl
-BuildRequires: perl(File::Temp)
-BuildRequires: perl(Pod::Coverage)
-BuildRequires: perl(Test::Pod)
-BuildRequires: perl(Test::Pod::Coverage)
+BuildRequires:  perl(Compress::Zlib)
 BuildRequires: perl(Digest::MD5)
+BuildRequires:  perl(Directory::Queue)
+BuildRequires:  perl(Directory::Queue::Simple)
+BuildRequires:  perl(Encode)
+BuildRequires:  perl(Exporter)
 BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(File::Temp)
 BuildRequires: perl(JSON)
 BuildRequires: perl(MIME::Base64)
 BuildRequires: perl(Params::Validate)
+BuildRequires:  perl(Pod::Coverage) >= 0.18
 BuildRequires: perl(Test::More)
-Requires:      perl(Digest::MD5)
-Requires:      perl(JSON)
-Requires:      perl(MIME::Base64)
-Requires:      perl(Params::Validate)
+BuildRequires:  perl(Test::Pod) >= 1.22
+BuildRequires:  perl(Test::Pod::Coverage) >= 1.08
 Requires:      perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

 %description
@@ -61,4 +62,3 @@
 %changelog
 * Wed Dec 07 2011 Lionel Cons <lionel.cons at cern.ch> 0.7-1
 - Specfile autogenerated by cpanspec 1.78.
-


> > TODO: Remove useless BuildRoot definition, its delete in %install and whole
> > %clean section. They are no needed anymore.
> > TODO: Remove useless %defattr macro from %files section.
> Please note that we are also targeting RHEL 5.
Ok.

> TODO: Build-require perl(Encode) for tests (t/2serialize.t:6).
+BuildRequires:  perl(Encode)
Ok.

> TODO: Build-require perl(Exporter) for tests (lib/Messaging/Message.pm:23).
+BuildRequires:  perl(Exporter)
Ok.

> FIX: Build-require perl(Compress::Zlib) for optional tests
> (t/2serialize.t:11).
+BuildRequires:  perl(Compress::Zlib)
Ok.

> FIX: Build-require perl(Directory::Queue) for optional tests (t/2queue.t:47).
> FIX: Build-require perl(Directory::Queue::Simple) for optional tests
> (t/2queue.t:53).
+BuildRequires:  perl(Directory::Queue)
+BuildRequires:  perl(Directory::Queue::Simple)
Ok.

> TODO: Sort Build-Requires lexicographically to make package maintenance easier.
Ok.

> TODO: Do not package useless VERSION file.
Not addressed. Ok.


All tests pass. Ok.

$ rpmlint perl-Messaging-Message.spec
../SRPMS/perl-Messaging-Message-0.7-2.fc17.src.rpm
../RPMS/noarch/perl-Messaging-Message-0.7-2.fc17.noarch.rpm 
perl-Messaging-Message.noarch: W: incoherent-version-in-changelog 0.7-1
['0.7-2.fc17', '0.7-2']
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

TODO: Update release number in %changelog entry.

> TODO: Remove explicit Requires that are auto-detected: perl(Digest::MD5),
> perl(JSON), perl(MIME::Base64), perl(Params::Validate)
$ rpm -q --requires -p
../RPMS/noarch/perl-Messaging-Message-0.7-2.fc17.noarch.rpm | sort | uniq -c
      1 perl(Digest::MD5)  
      1 perl(Encode)  
      1 perl(Exporter)  
      1 perl(JSON)  
      1 perl(Messaging::Message)  
      1 perl(MIME::Base64)  
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(Params::Validate)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Messaging-Message-0.7-2.fc17.noarch.rpm 
Binary dependencies resolvable. Ok.

Package build in Koji
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3641670). Ok.

Package is in line with Fedora and Perl packaging guidelines.


Please consider fixing all `TODO' items before building the package.
Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.