[Bug 773021] Review Request: piglit - Collection of automated tests for OpenGL implementations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=773021

--- Comment #11 from Matěj Cepl <mcepl at redhat.com> 2012-01-13 16:04:50 EST ---
(In reply to comment #10)
> 1. You're shipping the GPL-2 file twice:
> /usr/share/doc/piglit-1/GPL-2
> and
> /usr/share/doc/piglit-1/documentation/GPL-2
> I suggest you remove /usr/share/doc/piglit-1/documentation/ as it contains only
> GPL-2.

I just don't install documentation directory now.

> 2. You're shipping cmake files and the generated Makefile:
> ....
> Please remove these files if they're useless.

Most of them removed (removing more would be probably not cost:benefit
positive).

> [?]: MUST Package contains no bundled libraries.
> 
> Pending FESCO approval glew bundling in: https://fedorahosted.org/fpc/ticket/132
> If you could get a knowledgable MESA developer like ajax to take a look at the
> list of piglit patches in: https://bugzilla.redhat.com/show_bug.cgi?id=773021#c3
> and make a recommendataion one way or another I'm sure it'll help.

I have discussed that with ajax and airlied yesterday and they seemed generally
positive to bundling. It is just too much work for no benefit (there are no
secuirty issues with piglit).

> [x]: MUST Changelog in prescribed format.
> [-]: MUST Package has no %clean section with rm -rf %{buildroot} (or
> $RPM_BUILD_ROOT)
> Note: Clean is needed only if supporting EPEL

And yes, of course, I want to support EPEL in the first place (we use piglit
for the internal RH testing of RHEL).

> Note that the piglit-summary-html report shows a few tests turning from fail to
> pass and vice versa just from running quick.tests twice on the same machine, so
> actaully interpreting test results for QA could get "interesting".

That's interseting ... which ones? Isn't it a bug in piglit?

> [x]: SHOULD Package should compile and build into binary rpms on all supported
> architectures.

Built in koji on all non-excluded RHEL-6 platforms.

package piglit-1-0.12.git20120110Rf26fbd0.el6.src.rpm is in the same folder as
previous ones, .spec file as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.