[Bug 664912] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664912

--- Comment #13 from Petr Pisar <ppisar at redhat.com> 2012-01-16 07:22:44 EST ---
This is rebase to 0.15. Performing complete review.

Source tar ball is original. Ok.
Summary verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
License verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
URL and Source0 verified. Ok.

FIX: Augment description text to cover this package. Current sentence talks
about different Perl package only.

No XS code, noarch BuildArch is Ok.

FIX: Build-require perl(Carp) (lib/HTML/TreeBuilder/LibXML/Node.pm:4).
TODO: Build-require perl(base) (lib/HTML/TreeBuilder/LibXML.pm:6)

TODO: Remove useless %defattr from %files section.

All tests pass. Ok.

$ rpmlint perl-HTML-TreeBuilder-LibXML.spec
../SRPMS/perl-HTML-TreeBuilder-LibXML-0.15-1.fc17.src.rpm
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.15-1.fc17.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.15-1.fc17.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan 16 13:03
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.15
-rw-r--r--    1 root    root                     2461 Nov 29 19:21
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.15/Changes
-rw-r--r--    1 root    root                      576 Sep 21 00:50
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.15/README
-rw-r--r--    1 root    root                     2469 Jan 16 13:03
/usr/share/man/man3/HTML::TreeBuilder::LibXML.3pm.gz
-rw-r--r--    1 root    root                     2045 Jan 16 13:03
/usr/share/man/man3/HTML::TreeBuilder::LibXML::Node.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan 16 13:03
/usr/share/perl5/vendor_perl/HTML
drwxr-xr-x    2 root    root                        0 Jan 16 13:03
/usr/share/perl5/vendor_perl/HTML/TreeBuilder
drwxr-xr-x    2 root    root                        0 Jan 16 13:03
/usr/share/perl5/vendor_perl/HTML/TreeBuilder/LibXML
-rw-r--r--    1 root    root                     3925 Nov 29 19:21
/usr/share/perl5/vendor_perl/HTML/TreeBuilder/LibXML.pm
-rw-r--r--    1 root    root                     5905 Nov 29 19:20
/usr/share/perl5/vendor_perl/HTML/TreeBuilder/LibXML/Node.pm
File permissions and layout are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.15-1.fc17.noarch.rpm | sort |
uniq -c 
      1 perl >= 0:5.008001
      1 perl(base)  
      1 perl(Carp)  
      1 perl(HTML::TreeBuilder::LibXML::Node)  
      1 perl(HTML::TreeBuilder::XPath) >= 0.14
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(strict)  
      1 perl(warnings)  
      1 perl(XML::LibXML) >= 1.7
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.15-1.fc17.noarch.rpm | sort |
uniq -c 
      1 perl(HTML::TreeBuilder::LibXML) = 0.15
      1 perl-HTML-TreeBuilder-LibXML = 0.15-1.fc17
      1 perl(HTML::TreeBuilder::LibXML::Node)
Binary provides Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.15-1.fc17.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3705598). ???

Otherwise package is in line with Fedora and Perl packaging guidelines.


Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and
provide new spec file.

Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.