[Bug 782786] Review Request: equalx - LaTeX Equation Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=782786

--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi> 2012-01-18 12:12:23 EST ---
rpmlint output:
equalx.x86_64: W: no-manual-page-for-binary equalx
3 packages and 0 specfiles checked; 0 errors, 1 warnings.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK

MUST: The package must be named according to the Package Naming Guidelines.
NEEDSWORK
- The Version should be 0.51 to be in accordance with the package naming
guidelines.
- However, the upstream page clearly states that this is supposed to be 0.5.1.
- Please ask that upstream sanitizes their tarball naming.

MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- Some source code files specify GPLv3+ license, while some specify the GPL (no
version) and others have no license headers at all.
- The attached LICENSE states that EqualX is distributed under GPLv3+.
The resulting license is thus GPLv3+. However, please ask upstream to add the
missing license boilerplates.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
397d5cfb6036212d66dd7baa0bba2a47  equalx_0.51.orig.zip
397d5cfb6036212d66dd7baa0bba2a47  ../SOURCES/equalx_0.51.orig.zip

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A

MUST: Optflags are used and time stamps preserved. NEEDSWORK
- Please use the '-p' flag for install.

MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned, architecture dependent dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.