[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770152

--- Comment #20 from Christophe Fergeau <cfergeau at redhat.com> 2012-01-19 05:28:20 EST ---
(In reply to comment #18)
> Issues:
> [!]: MUST Package successfully compiles and builds into binary rpms on at
>      least one supported architecture.
> [!]: MUST All build dependencies are listed in BuildRequires, except for any
>      that are listed in the exceptions section of Packaging Guidelines.
>      Note: The package did not built BR could therefore not be checked or the
>      package failed to build because of missing BR

I wanted to push a rawhide scratch build with koji to test this, but rawhide
seems to be broken atm :-/ 

DEBUG util.py:257:  Error: Package: clutter-gtk-1.1.2-2.fc17.x86_64 (build)
DEBUG util.py:257:             Requires: libcogl.so.6()(64bit)
DEBUG util.py:257:   You could try using --skip-broken to work around the
problem
DEBUG util.py:257:   You could try running: rpm -Va --nofiles --nodigest

( http://koji.fedoraproject.org/koji/taskinfo?taskID=3714490 )

> [!]: MUST Package consistently uses macros (instead of hard-coded directory
>      names).
>      Note: Using both %{buildroot} and $RPM_BUILD_ROOT

Yup, I agree it's probably confused by $RPM_BUILD_ROOT appearing in the
changelog

> [!]: MUST Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> /home/adam/Fedora/fedora-review/770152/gnome-boxes-3.3.4.tar.xz :
>   MD5SUM this package     : 2e203398f1912ddc47ba86ea7514d12e
>   MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
> 
> Could you check the tarball because of this checksum mismatch?

Started looking into this, the tarball on gnome.org has the same md5sum as the
one in my srpm (phew), I think what happens is that %global url_ver %(echo
%{version}|cut -d. -f1,2 doesn't work as expected, and
http://download.gnome.org/sources/%{name}/%{url_ver}/%{name}-%{version}.tar.xz
gives a 404 page which gives this d41d8cd md5sum. I'll investigate more

The "[!]: SHOULD Spec use %global instead of %define" is probably also a false
alarm due to %define being in the changelog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.