[Bug 783317] Review Request: akonadi-google - Akonadi Resources for accessing Google services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783317

Radek Novacek <rnovacek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rnovacek at redhat.com
         AssignedTo|nobody at fedoraproject.org    |rnovacek at redhat.com
               Flag|                            |fedora-review?

--- Comment #1 from Radek Novacek <rnovacek at redhat.com> 2012-01-20 06:27:34 EST ---
Name: ok
License: ok
Source: It should be stated clearly in the comment in specfile how can be the
tarball obtained from git
BRs/Reqs: see below
Macros used consistently: ok
ldconfig: ok
Desktop file validations: NA
Locales: NA
Docs: install at least README to %doc. According to guidelines you should also
ping upstream to add license to tarball.
Devel: ok
Files: ok
Build: ok
rpmlint: no need to fix
./akonadi-google.spec: W: invalid-url Source0:
akonadi-google-0.2-git754771b.tar.gz
akonadi-google-calendar.x86_64: W: no-documentation
akonadi-google-calendar.x86_64: W: no-manual-page-for-binary
akonadi_googlecalendar_resource
akonadi-google-contacts.x86_64: W: no-documentation
akonadi-google-contacts.x86_64: W: no-manual-page-for-binary
akonadi_googlecontacts_resource
akonadi-google-tasks.x86_64: W: no-documentation
akonadi-google-tasks.x86_64: W: no-manual-page-for-binary
akonadi_googletasks_resource
libkgoogle-devel.x86_64: W: spelling-error Summary(en_US) akonadi -> Kodiak
libkgoogle-devel.x86_64: W: spelling-error Summary(en_US) google -> Google,
goggle, googly
libkgoogle-devel.x86_64: W: spelling-error %description -l en_US akonadi ->
Kodiak
libkgoogle-devel.x86_64: W: spelling-error %description -l en_US google ->
Google, goggle, googly
libkgoogle-devel.x86_64: W: no-documentation

I have some comments to subpackages, its only my recommendations, I'm open to
other suggestions:
* contacts, calendar and tasks subpackage should Require: libkgoogle subpackage
with same version to prevent breakage on API/ABI change
* I would let the base package empty and add Requires to all subpackages
(except devel). This makes it easier for user to install all of them at once.
Add section %files without any content to generate base package too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.