[Bug 523877] Review Request: CBFlib - crystallography binary format library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523877

--- Comment #41 from Dmitrij S. Kryzhevich <krege at land.ru> 2012-01-23 04:56:39 EST ---
(-) rpmlint output:
CBFlib-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/CBFlib-0.9.2.3/examples/cbf2adscimg.c
CBFlib-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/CBFlib-0.9.2.3/examples/cbf2adscimg_sub.c

Need to fix permissions.

(+) Name ok.
(+) Spec ok.
(+) The package meets the Packaging Guidelines.
(+) License ok.
(+) Sources are matched upstream ones.
(+) The package was compiled on at least on x86_64, ok.
(+) Package post (un)install scrips call ldconfig.
(+) Package owns its directories, not owns others.
(+) %files section ok 

(-) Permissions are not set properly.

Fix permissions for debuginfo package. 

(+/-) Devel package contain all needed .so and headers, it has Requires:
%{name} = %{version}-%{release} string.

Goudelines ask "Requires: %{name}%{?_isa} = %{version}-%{release}".

Fix that isues - and I'l close review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.