[Bug 782220] Review Request: dlm - cluster infrastructure for dlm (distributed lock manager)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=782220

--- Comment #10 from Steven Dake <sdake at redhat.com> 2012-01-23 14:33:38 EST ---
Rather then just changing the spec file, can you build a new SRPM?  Make sure
to bump 
the Release field (ie: 1%{?dist} to 2%{?dist} and edit the changelog.

Change the BuildRequires for corosync to:

BuildRequires: corosync >= 1.99.0

Since this requires the corosync 1.99.0 headers to build, I can't approve this
package until corosync alpha is in rawhide (or the dlm package won't build and
trigger a bunch of spam email).  Honza will be putting it in shortly.


[root at beast SRPMS]# rpmlint dlm*src.rpm
dlm.src:36: E: hardcoded-library-path in %{buildroot}/lib/systemd/systemd-dlm
dlm.src:59: E: hardcoded-library-path in /lib/systemd/systemd-dlm
dlm.src: W: invalid-url Source0:
https://fedorahosted.org/releases/d/l/dlm/dlm-3.9.0.tar.gz HTTP Error 404: Not
Found
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

/lib/systemd/systemd-dlm seems invalid to me.  It is an init script.  Init
scripts are not needed in fedora 16+.  /lib/systemd binaries are meant as
support binaries for the systemd package.  This is why there are E returns for
the lib/systemd definition.

The source must be posted and have an upstream before it can be merged into
fedora.

The following things are currently in the FAIL state:
1. systemd-dlm should be removed (does this help the software function?)
2. no upstream sources
3. the sources in the src.rpm must match the upstream sources
4. The BuildRequires is commented out, blocking merging of the package

This package depends on the corosync alpha package, which hasn't been merged. 
Please address the other issues, post a new spec and srpm, and I'll finish the
review.  Then when Honza merges the new corosync, I can approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.