[Bug 740160] Review Request: discount - An implementation of the Markdown language in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=740160

--- Comment #15 from Martin Gieseking <martin.gieseking at uos.de> 2012-01-24 14:37:18 EST ---
The renaming of /usr/bin/markdown to /usr/bin/markdown_py simplifies things a
bit. However, python-markdown 2.1.0 was only pushed to rawhide (F17). The
current release branches still provide 2.0.3. Thus, if you want to build
discount for Fedora < 17 as well, you might want to ask the maintainer of
python-markdown whether it's possible to safely rename the binary. Since
python-markdown is required by a couple of critical packages (e.g.
bodhi-server, transifex) it's probably not a good idea to update to 2.1.0 in
F16.

Concerning the demo programs, I think the prefixed names discount-* are fine. 

I'll have a closer look at your SRPM in the next couple of days. Currently, I'm
too busy. Just a quick note: You should not add files more than once, so drop
the %doc files from the base package. They are installed by its dependency
libmarkdown.

If you don't have a sponsor yet, I can sponsor you. But I would like you to do
some informal reviews to show a basic understanding of the packaging and review
guidelines. Just pick a yet uncommented review request (one that's not blocked
by FE-NEEDSPONSOR) from the review queue [1], check the items from list [2],
and post your comments into the bug ticket.

[1] http://fedoraproject.org/PackageReviewStatus/NEW.html
[2] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.