[Bug 783151] Review Request: FlightCrew - EPUB validation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783151

Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Dan Horák <dan at danny.cz> 2012-01-25 06:48:22 EST ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK source files match upstream:
     16afdb4fcb30275070907c27857f89930bd8a322  FlightCrew-0.7.2-Code.zip
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv3+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A* %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths with scriptlet
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- rpmlint says
FlightCrew.x86_64: W: spelling-error %description -l en_US epub -> pub, e pub
FlightCrew.x86_64: W: spelling-error %description -l en_US validator ->
lavatorial
FlightCrew.x86_64: W: no-manual-page-for-binary flightcrew-cli
FlightCrew.src: W: spelling-error %description -l en_US epub -> pub, e pub
FlightCrew.src: W: spelling-error %description -l en_US validator -> lavatorial
FlightCrew.src: W: invalid-url Source0:
http://flightcrew.googlecode.com/files/FlightCrew-0.7.2-Code.zip HTTP Error
404: Not Found
FlightCrew-devel.x86_64: W: no-documentation
    => nothing blocks the review
- when googlemock is included in fedora, the test-suite could be built and run
- in some future iteration the standalone gui validator could be also built

The package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.