[Bug 782220] Review Request: dlm - cluster infrastructure for dlm (distributed lock manager)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=782220

--- Comment #14 from Steven Dake <sdake at redhat.com> 2012-01-26 14:03:49 EST ---
The first section uses mixed tabs and spaces.  I've attached a patch to fix. 
Please integrate that patch to the spec file.

with patch:

[root at beast SRPMS]# rpmlint dlm-3.99.0-1.fc16.src.rpm
dlm.src:3: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[root at beast x86_64]# rpmlint dlm-3.99.0-1.fc16.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[root at beast x86_64]# rpmlint dlm-debuginfo-3.99.0-1.fc16.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[root at beast x86_64]# rpmlint dlm-devel-3.99.0-1.fc16.x86_64.rpm
dlm-devel.x86_64: W: no-dependency-on dlm/dlm-libs/libdlm
dlm-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[root at beast x86_64]# rpmlint dlm-lib-3.99.0-1.fc16.x86_64.rpm
dlm-lib.x86_64: W: spelling-error %description -l en_US userland -> user land,
user-land, slanderous
dlm-lib.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

I would recommend changing userland to "user-land" or "user land"

Please put README.license in a %doc of the files section of dlm-devel

[PASS] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

[root at beast SPECS]# wget http://people.redhat.com/teigland/dlm-3.99.0.tar.gz
--2012-01-26 11:59:04--  http://people.redhat.com/teigland/dlm-3.99.0.tar.gz
Resolving people.redhat.com... 10.5.19.30
Connecting to people.redhat.com|10.5.19.30|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 95490 (93K) [application/x-gzip]
Saving to: “dlm-3.99.0.tar.gz”

100%[======================================>] 95,490       148K/s   in 0.6s    

2012-01-26 11:59:05 (148 KB/s) - “dlm-3.99.0.tar.gz” saved [95490/95490]

[root at beast SPECS]# sha256sum dlm-3.99.0.tar.gz
2c21065a6eac6a2ce24b3121aab0e9cf2dfce7ed15133b34ffdc0d98e2af47d5 
dlm-3.99.0.tar.gz

[root at beast SOURCES]# sha256sum dlm-3.99.0.tar.gz
2c21065a6eac6a2ce24b3121aab0e9cf2dfce7ed15133b34ffdc0d98e2af47d5 
dlm-3.99.0.tar.gz

To address before fedora-review+:
include readme.license in the %doc section of the devel package
apply patch to spec file to fix tabs/spaces issue in the header

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.