[Bug 784849] Review Request: ksecrets - Secrets management infrastructure for KDE

Fri Jan 27 00:48:44 UTC 2012

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=784849

john5342 <john5342 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from john5342 <john5342 at gmail.com> 2012-01-26 19:48:43 EST ---
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
[!]: MUST Development .so files in -devel subpackage, if present.
     Note: ksecrets-4.8.0-1.fc17.i686.rpm : /usr/lib/kde4/kcm_ksecretsync.so
     ksecrets-4.8.0-1.fc17.i686.rpm : /usr/lib/kde4/kio_ksecretsservice.so

These are just unversioned and also not in the global libdir. Ignore

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[-]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint ksecrets-4.8.0-1.fc17.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint ksecrets-devel-4.8.0-1.fc17.i686.rpm

ksecrets-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

ksecrets-devel requires the base package which does have documentation

rpmlint ksecrets-4.8.0-1.fc17.i686.rpm

ksecrets.i686: W: no-manual-page-for-binary kwl2kss
ksecrets.i686: W: no-manual-page-for-binary ksecretsserviced
ksecrets.i686: W: no-manual-page-for-binary ksecrets
ksecrets.i686: W: no-manual-page-for-binary ksecretsync
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

These are unfortunate and should really have man pages but they are really more
api type functions rather than end user functions. Should ideally bug upstream
about getting some docs but not a showstopper in my book.

rpmlint ksecrets-debuginfo-4.8.0-1.fc17.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/remotes/lockdown3/FedoraReviews/ksecrets/ksecrets-4.8.0.tar.bz2 :
  MD5SUM this package     : fa126591e8da34e16b65ecfad9f3907a
  MD5SUM upstream package : fa126591e8da34e16b65ecfad9f3907a

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[-]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD Scriptlets must be sane, if used.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[!]: MUST Rpmlint output is silent.
Full output above but these are the only ones that are potentially worth doing
something about
ksecrets.i686: W: no-manual-page-for-binary kwl2kss
ksecrets.i686: W: no-manual-page-for-binary ksecretsserviced
ksecrets.i686: W: no-manual-page-for-binary ksecrets
ksecrets.i686: W: no-manual-page-for-binary ksecretsync
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Generated by fedora-review 0.1.2
External plugins:

Should really query upstream about the 2 issues but nothing that is critical
for review.

ACCEPT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.