[Bug 717920] Review Request: rubygem-hike - Find files in a set of paths

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717920

--- Comment #3 from Vít Ondruch <vondruch at redhat.com> 2012-01-30 04:34:18 EST ---
(In reply to comment #2)
> - Please update to the latest version of gem (currently 1.2.1).

Done

> - The specfile you provided differs from the specfile in SRPM (just the two
> comments in %check, but please fix this).

Done

> - License is MIT, not GPLv2+ or Ruby.

Done

> - Please consider updating to the new standard of Rubygems packaging for
> Rawhide with Ruby 1.9.3 [1] (and please build the package with new Ruby, not
> the old one - use f17-ruby target in Koji).

Done

> - Otherwise the package looks good, but I'd like to see it once more after it
> gets updated to the latest version, then I'll gladly approve it.
> 
> [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby

Spec URL: http://people.redhat.com/vondruch/rubygem-hike.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-hike-1.2.1-1.fc17.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745471

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.